Update core timestamp to string to match other date fields#60
Draft
Update core timestamp to string to match other date fields#60
Conversation
Contributor
|
Let's hold off on this as it doesn't really add value but does case a pretty good breaking change. The original justification for the ISO was that the database stores DateTime, not timestamps, so we do a bunch of conversion. The message envelope doesn't need to be human readable and using timestamps makes certain things at that level of the process simpler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the core bottle timestamp to a string for ISO datetime like all the other datetime fields we have.
This will need a change to the elixir branch as well.